Skip to content

Use better colours for title buttons #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 2 commits into from
Jul 7, 2023
Merged

Use better colours for title buttons #2589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bda763
Changes buttons to avoid custom styling
robertbrignull Jul 6, 2023
bf087d2
Merge branch 'main' into robertbrignull/data-title-buttons-background
robertbrignull Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions extensions/ql-vscode/src/view/data-extensions-editor/LibraryRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ const ModeledPercentage = styled.span`
color: var(--vscode-descriptionForeground);
`;

const TitleButton = styled(VSCodeButton)`
background-color: transparent;

&:hover {
pointer: cursor;
background-color: var(--vscode-button-secondaryBackground);
}
`;

const ButtonsContainer = styled.div`
display: flex;
gap: 0.4em;
Expand Down Expand Up @@ -142,14 +133,14 @@ export const LibraryRow = ({
</ModeledPercentage>
{hasUnsavedChanges ? <VSCodeTag>UNSAVED</VSCodeTag> : null}
</NameContainer>
<TitleButton onClick={handleModelWithAI}>
<VSCodeButton appearance="icon" onClick={handleModelWithAI}>
<Codicon name="lightbulb-autofix" label="Model with AI" />
&nbsp;Model with AI
</TitleButton>
<TitleButton onClick={handleModelFromSource}>
</VSCodeButton>
<VSCodeButton appearance="icon" onClick={handleModelFromSource}>
<Codicon name="code" label="Model from source" />
&nbsp;Model from source
</TitleButton>
</VSCodeButton>
</TitleContainer>
{isExpanded && (
<>
Expand Down