Skip to content

Remove support for CodeQL CLI versions older than 2.9.4 #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shati-patel merged 2 commits into from
Jul 14, 2023
Merged

Remove support for CodeQL CLI versions older than 2.9.4 #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ad9896
Remove support for CodeQL CLI versions older than 2.9.4
shati-patel Jul 14, 2023
aac5049
Merge branch 'main' into shati-patel/old-cli
shati-patel Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/ql-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@

## [UNRELEASED]

- Remove support for CodeQL CLI versions older than 2.9.4. [#2610](https://github.com/github/vscode-codeql/pull/2610)
- Implement syntax highlighting for the `additional` and `default` keywords. [#2609](https://github.com/github/vscode-codeql/pull/2609)

## 1.8.7 - 29 June 2023

- Show a run button on the file tab for query files, that will start a local query. This button will only show when a local database is selected in the extension. [#2544](https://github.com/github/vscode-codeql/pull/2544)
- Add `CodeQL: Quick Evaluation Count` command to generate the count summary statistics of the results set
without speding the time to compute locations and strings.
without spending the time to compute locations and strings.

## 1.8.6 - 14 June 2023

Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/codeql-cli/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,7 +1790,7 @@ export function shouldDebugCliServer() {
export class CliVersionConstraint {
// The oldest version of the CLI that we support. This is used to determine
// whether to show a warning about the CLI being too old on startup.
public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.7.6");
public static OLDEST_SUPPORTED_CLI_VERSION = new SemVer("2.9.4");

/**
* CLI version where building QLX packs for remote queries is supported.
Expand Down
2 changes: 0 additions & 2 deletions extensions/ql-vscode/supported_cli_versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"v2.13.5",
"v2.12.7",
"v2.11.6",
"v2.7.6",
Copy link
Contributor

@robertbrignull robertbrignull Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering within this list 🙈 😱 (not your fault)

"v2.8.5",
"v2.9.4",
"v2.10.5",
"nightly"
Expand Down