Merge definitions of Disposable where possible#2628
Merged
robertbrignull merged 1 commit intomainfrom Jul 24, 2023
Merged
Conversation
aeisenberg
previously approved these changes
Jul 21, 2023
charisk
reviewed
Jul 21, 2023
Contributor
There was a problem hiding this comment.
I think the intention with packages/commands is that it's a stand-alone package that we could potentially publish to npm one day. So I think we need to leave this implementation here.
Contributor
Author
There was a problem hiding this comment.
Ok, I'll revert that one.
It would be better for the future if this requirement were enforced or documented in the code, so we don't have to rely on remembering it.
Revoking my approval since @charisk brings up a point I hadn't considered.
ae47014 to
f1a9289
Compare
Contributor
Author
|
PR is updated to just remove the instance from |
charisk
approved these changes
Jul 21, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
Thank you for tidying that up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had three identical versions of
Disposabletypes, all with the intention of avoiding a dependency on VS Code. I propose we can merge them all and just use the one fromdisposable-objects.ts. That file is already incommonand has a comment at the top saying to avoid dependencies on VS Code.Checklist
ready-for-doc-reviewlabel there.