Skip to content

Merge definitions of Disposable where possible #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 1 commit into from
Jul 24, 2023
Merged

Merge definitions of Disposable where possible #2628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions extensions/ql-vscode/src/log-insights/log-scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { SummaryEvent } from "./log-summary";
import { readJsonlFile } from "../common/jsonl-reader";
import { Disposable } from "../common/disposable-object";

/**
* Callback interface used to report diagnostics from a log scanner.
Expand Down Expand Up @@ -62,13 +63,6 @@ export interface EvaluationLogScannerProvider {
): EvaluationLogScanner;
}

/**
* Same as VSCode's `Disposable`, but avoids a dependency on VS Code.
*/
export interface Disposable {
dispose(): void;
}

export class EvaluationLogScannerSet {
private readonly scannerProviders = new Map<
number,
Expand Down