Skip to content

Remove config.codeQL.dataExtensions.modelDetailsView feature flag#2730

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/details-ship
Aug 21, 2023
Merged

Remove config.codeQL.dataExtensions.modelDetailsView feature flag#2730
robertbrignull merged 1 commit intomainfrom
robertbrignull/details-ship

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull commented Aug 21, 2023

This effectively ships the data extensions model details view, though it is still hidden behind the main feature flag for the data extensions editor.

I've opened this PR but it doesn't have to be merged until we're happy with the state of the new panel.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners August 21, 2023 11:41
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertbrignull robertbrignull merged commit 13ce5f7 into main Aug 21, 2023
@robertbrignull robertbrignull deleted the robertbrignull/details-ship branch August 21, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants