Skip to content

Remove config.codeQL.dataExtensions.modelDetailsView feature flag #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 1 commit into from
Aug 21, 2023
Merged

Remove config.codeQL.dataExtensions.modelDetailsView feature flag #2730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/ql-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,7 +1763,7 @@
{
"id": "codeQLModelDetails",
"name": "CodeQL Model Details",
"when": "config.codeQL.canary && config.codeQL.dataExtensions.modelDetailsView && codeql.dataExtensionsEditorOpen"
"when": "config.codeQL.canary && codeql.dataExtensionsEditorOpen"
}
]
},
Expand Down
5 changes: 0 additions & 5 deletions extensions/ql-vscode/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,11 +713,6 @@ const EXTENSIONS_DIRECTORY = new Setting(
"extensionsDirectory",
DATA_EXTENSIONS,
);
const MODEL_DETAILS_VIEW = new Setting("modelDetailsView", DATA_EXTENSIONS);

export function showModelDetailsView(): boolean {
return !!MODEL_DETAILS_VIEW.getValue<boolean>();
}

export function showLlmGeneration(): boolean {
return !!LLM_GENERATION.getValue<boolean>();
Expand Down
10 changes: 2 additions & 8 deletions extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@ import { readQueryResults, runQuery } from "./external-api-usage-query";
import { ExternalApiUsage, Usage } from "./external-api-usage";
import { ModeledMethod } from "./modeled-method";
import { ExtensionPack } from "./shared/extension-pack";
import {
enableFrameworkMode,
showLlmGeneration,
showModelDetailsView,
} from "../config";
import { enableFrameworkMode, showLlmGeneration } from "../config";
import { Mode } from "./shared/mode";
import { loadModeledMethods, saveModeledMethods } from "./modeled-method-fs";
import { join } from "path";
Expand Down Expand Up @@ -280,9 +276,7 @@ export class DataExtensionsEditorView extends AbstractWebview<
}

protected async handleJumpToUsage(usage: Usage) {
if (showModelDetailsView()) {
await this.revealItemInDetailsPanel(usage);
}
await this.revealItemInDetailsPanel(usage);
await showResolvableLocation(usage.url, this.databaseItem, this.app.logger);
}

Expand Down