Skip to content

Bump nanoid from 3.3.6 to 5.0.1 in /extensions/ql-vscode#2818

Merged
koesie10 merged 2 commits intomainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1
Oct 3, 2023
Merged

Bump nanoid from 3.3.6 to 5.0.1 in /extensions/ql-vscode#2818
koesie10 merged 2 commits intomainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Sep 14, 2023

Bumps nanoid from 3.3.6 to 5.0.1.

Changelog

Sourced from nanoid's changelog.

5.0.1

  • Fixed Node.js 18 support.

5.0

  • Moved Node.js version to Web Crypto API.
  • Removed async API since Web Crypto API has only sync version.
  • Removed Node.js 14 and 16 support.

4.0.2

  • Added link to Github Sponsors.

4.0.1

4.0

  • Removed CommonJS support. Nano ID 4 will work only with ESM applications. We will support 3.x branch with CommonJS for users who can’t migrate to ESM.
  • Removed Node.js 10 and Node.js 12 support.
  • Reduced npm package size.
Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
nanoid [>= 4.a, < 5]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 14, 2023 13:29
@dependabot dependabot bot added the Update dependencies Dependabot update PRs label Sep 14, 2023
@robertbrignull
Copy link
Copy Markdown
Contributor

Tests are failing with:

        SyntaxError: Cannot use import statement outside a module

           7 | import { BaseLogger, Logger } from "../common/logging";
           8 | import { basename, join } from "path";
        >  9 | import { nanoid } from "nanoid";

@koesie10
Copy link
Copy Markdown
Member

@robertbrignull I don't think we can upgrade this dependency to version 5 since that drops Node 16 support. Version 4 drops CommonJS support and only supports ESM modules which doesn't seem to be supported by Jest, so we can't really upgrade to that version either.

@koesie10 koesie10 closed this Sep 25, 2023
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Sep 25, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1 branch September 25, 2023 10:13
@koesie10 koesie10 restored the dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1 branch October 3, 2023 08:11
@koesie10
Copy link
Copy Markdown
Member

koesie10 commented Oct 3, 2023

Let's try if we can update this dependency now that we're on Node 18. I'm not sure if ESM is a problem for this dependency since we're not mocking nanoid in any tests.

@dependabot recreate

@koesie10 koesie10 reopened this Oct 3, 2023
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.6 to 5.0.1.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.6...5.0.1)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1 branch from 9cd1b12 to 99dabb0 Compare October 3, 2023 08:13
@koesie10 koesie10 merged commit a525499 into main Oct 3, 2023
@koesie10 koesie10 deleted the dependabot/npm_and_yarn/extensions/ql-vscode/nanoid-5.0.1 branch October 3, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Update dependencies Dependabot update PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants