Merged
Conversation
robertbrignull
approved these changes
Jan 22, 2024
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM
One question which maybe doesn't have to be answered right now, and could get answered on its own as we flesh out this object. But could be good to think about now anyway so we avoid creating incorrect documentation.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generateQueryPackfunction inrun-remote-query.tscurrently has logic to calculate a few things like the QL pack root, paths to the query files, the language, etc. In order to add multi-query support, a few of these calculations need to be moved further up the stack and then passed in togenerateQueryPackas arguments.In this PR, we're introducing a new type (
QlPackDetails) in the/variant-analysisdomain to hold such information so that a single object can be passed in togenerateQueryPackand using that to include thequeryFile. In follow up PRs, we'll also need to move the language, and other related information. We'll also transition from a singularqueryFileto multiple ones.I'm not 100% convinced on the
QlPackDetailsname, so open to suggestions! We can also rename this once it has been fleshed out a bit more.Checklist
N/A:
ready-for-doc-reviewlabel there.