Skip to content

Move QL pack root path to the QlPackDetails#3267

Merged
charisk merged 1 commit intomainfrom
charisk/move-ql-pack-root
Jan 23, 2024
Merged

Move QL pack root path to the QlPackDetails#3267
charisk merged 1 commit intomainfrom
charisk/move-ql-pack-root

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 23, 2024

Continues the work started in #3260 and #3262, and now moves the QL pack root path retrieval out of generateQueryPack.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner January 23, 2024 11:46
Comment thread extensions/ql-vscode/src/variant-analysis/run-remote-query.ts
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@charisk charisk merged commit 67e2ff3 into main Jan 23, 2024
@charisk charisk deleted the charisk/move-ql-pack-root branch January 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants