CodeQL model editor: Show access path suggestions in the webview#3305
CodeQL model editor: Show access path suggestions in the webview#3305shati-patel merged 4 commits intomainfrom
Conversation
|
|
||
| const Container = styled.div` | ||
| width: 430px; | ||
| display: flex; |
koesie10
left a comment
There was a problem hiding this comment.
Would we already expect the icon and details to be visible in the suggestions as well? It currently seems to be missing (probably because we're not passing getIcon and getDetails).
Also, it seems like for some type models, we're not able to edit anything, while for others, we are. This might be unrelated to your changes.
I think we can also use the suggest box for the type path (i.e. the text field shown in the input field for type models), but this would need to use the output suggestions (since the ReturnValue is valid for type models). This can also be done in a follow-up PR.
Woops, I definitely just forgot to add them 😅 Done now in the latest commit: (I stole the styling for the icon from the storybook example)
Hmm yes 🤔 I can take a look at the type paths etc in a separate PR! |




Reads the access path suggestions (from #3304 and previous PRs) in the webview and shows them in a "suggest box":
This is only enabled for Ruby, so the public model editor (i.e. for Java & C#) is unaffected. See internal linked issue for more details 🔗
❓ Should this have a view test? The
SuggestBoxcomponent is already tested, so I wasn't sure if it made sense to test e.g. theModelInputSuggestBoxseparately too.Checklist
N/A—still feature-flagged for internal use 🦞
ready-for-doc-reviewlabel there.