CodeQL model editor: Use suggest box for type path suggestions#3316
Merged
shati-patel merged 2 commits intomainfrom Feb 6, 2024
Merged
CodeQL model editor: Use suggest box for type path suggestions#3316shati-patel merged 2 commits intomainfrom
shati-patel merged 2 commits intomainfrom
Conversation
(I'd accidentally copied some outdated code from before we'd added the type textbox)
koesie10
approved these changes
Feb 6, 2024
Member
koesie10
left a comment
koesie10
left a comment
There was a problem hiding this comment.
LGTM, but we paired on this, so you may want to get another review
robertbrignull
approved these changes
Feb 6, 2024
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Looks reasonable to me too, just from looking at the code. Sadly I couldn't try it out as I got some errors relating to not having the latest queries. Sometime would be nice to get it working for me so I can follow along, but doesn't need to block this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Paired with @koesie10 🍐)
As suggested in #3305 (review), we can also use the
SuggestBoxfor "Type" methods (specifically for path suggestions). This technically uses theoutputAccessPathSuggestionsbecauseReturnValueis a valid value.Second commit is another small fix from that same PR review comment!
Checklist
N/A—feature-flagged for internal use only 🔐
ready-for-doc-reviewlabel there.