Skip to content

Move findDirWithFile to files.ts#3452

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/findDirWithFile
Mar 11, 2024
Merged

Move findDirWithFile to files.ts#3452
robertbrignull merged 1 commit intomainfrom
robertbrignull/findDirWithFile

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

The findDirWithFile function is pretty general and I'd argue belongs in files.ts more than it does in database-fetcher.ts. This refactoring is not a huge win in itself but it helps move towards a few goals:

  • make database-fetcher.ts smaller and more focussed, and make a future refactoring I want to do easier
  • moves the tests of this function out of vscode-tests/no-workspace and into unit-test
  • helps us remove the test/vscode-tests/no-workspace/databases/database-fetcher.test.ts file entirely so that the only remaining tests of database-fetcher.ts are test/vscode-tests/cli-integration/databases/database-fetcher.test.ts

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👌🏽

@robertbrignull robertbrignull merged commit 5402cab into main Mar 11, 2024
@robertbrignull robertbrignull deleted the robertbrignull/findDirWithFile branch March 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants