Move convertGithubNwoToDatabaseUrl to databases/github-databases/api.ts#3453
Merged
robertbrignull merged 1 commit intomainfrom Mar 11, 2024
Merged
Conversation
shati-patel
approved these changes
Mar 7, 2024
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks sensible! Thanks 🧹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Builds upon the #3452 PR because otherwise it'll just conflict. The changes aren't related except that the functions being moved are next to each other.)
I argue that the
convertGithubNwoToDatabaseUrlfunction (andpromptForLanguagewhich it uses) aren't particularly about fetching or importing databases and are more about interacting with the GitHub API, though I do realise the distinction isn't particularly clear.These functions also stand out from the rest of
database-fetcher.tsbecause they don't require arguments likeDatabaseManager,storagePath: string, orCodeQLCliServer, while almost all of the other functions do.I think it's neater to pull these functions out and move them to
databases/github-databases/api.tsinstead. This puts them next tolistDatabaseswhich makes sense as they largely just act on the output of that function.Checklist
ready-for-doc-reviewlabel there.