Fire an event when clicking the "model alerts indicator" button#3516
Merged
shati-patel merged 3 commits intomainfrom Mar 27, 2024
Merged
Fire an event when clicking the "model alerts indicator" button#3516shati-patel merged 3 commits intomainfrom
shati-patel merged 3 commits intomainfrom
Conversation
charisk
approved these changes
Mar 27, 2024
| return null; | ||
| } | ||
|
|
||
| const revealInModelAlertsView = () => |
Contributor
There was a problem hiding this comment.
I'd just inline the code from sendRevealInModelAlertsViewMessage instead of having a separate function. Removes an unnecessary level of indirection.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the model editor, you can click the "model alerts indicator" which will (eventually) open the corresponding alerts in the model alerts view.
For now, this PR just adds some types etc to fire a "reveal in model alerts view" event when you click this button. In the next PR I'll add the logic for the model alerts view to listen for those events and do the relevant thing.
Checklist
N/A, feature-flagged for internal use/testing
ready-for-doc-reviewlabel there.