Skip to content

Link from alerts indicator to model alerts view#3520

Merged
shati-patel merged 3 commits intomainfrom
shati-patel/reveal-model
Mar 28, 2024
Merged

Link from alerts indicator to model alerts view#3520
shati-patel merged 3 commits intomainfrom
shati-patel/reveal-model

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Mar 27, 2024

Follow-up to #3516. When you click a "model alerts indicator" (in the model editor), it will open the corresponding model in the model alerts view:

reveal-model.mp4

⚠️ Note: The model alerts view uses mock data at the moment, so we just open the view and don't auto-scroll to a specific model yet. This behaviour is something to test properly once we have alert provenance!

Checklist

N/A, feature-flagged for internal use/testing

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel force-pushed the shati-patel/reveal-model branch from 9b7278e to 7017f3c Compare March 27, 2024 16:35
@shati-patel shati-patel marked this pull request as ready for review March 27, 2024 16:41
@shati-patel shati-patel requested review from a team as code owners March 27, 2024 16:41
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread extensions/ql-vscode/src/model-editor/model-alerts/model-alerts-view.ts Outdated
Comment thread extensions/ql-vscode/src/view/model-editor/ModelAlertsIndicator.tsx
@shati-patel shati-patel enabled auto-merge (squash) March 28, 2024 10:18
@shati-patel shati-patel merged commit 45e20f4 into main Mar 28, 2024
@shati-patel shati-patel deleted the shati-patel/reveal-model branch March 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants