Adds Mac OS branch for the rotating log file opened at startup - #354
Merged
Conversation
Collaborator
atsju
self-requested a review
August 4, 2026 06:19
atsju
approved these changes
Aug 4, 2026
atsju
left a comment
Collaborator
There was a problem hiding this comment.
I agree with @gr5 I prefer it this way too. Single location is easyer to understand by end users even if it's old school.
On windows, the logs would end in C:/Users/<USER>/AppData/Roaming/<APPNAME>. A better place would probably be HomeLocation but I dislike when applications do that too.
Contributor
Author
|
I understand how the generic writable directory handed by the OS can be annoying for users who want to actually access the log. I'm fine with keeping the conditional then. |
Collaborator
|
As this change does not affect any functionality and has no risk on windows I'm merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #353
I think we could remove the branching and standardize on getting a writable directory through
QStandardPaths::writableLocation, what do you think ?