test: fix vacuous assertions in create_work_item and update_work_item

[github-actions]

Test Suite Reduction: src/safe_outputs/create_work_item.rs + update_work_item.rs

What was wrong

• test_validation_rejects_short_title (create_work_item): used bare assert!(result.is_err()) — confirms some error occurred but not which validation rule fired, so a regression that changes the error could pass unnoticed.
• test_validation_rejects_short_description (create_work_item): same problem — bare assert!(result.is_err()) with no message check.
• test_validation_rejects_tag_with_semicolon (create_work_item): bare assert!(result.is_err()) with no message check, despite a descriptive error message being available.
• test_params_validates_title_length (update_work_item): bare assert!(result.is_err()) — doesn't verify the "255 characters or fewer" message.

In addition, the two bare ensure!() calls in CreateWorkItemParams::validate() had no error messages, so any assertion against them would have been forced to match anyhow's internal condition-rendering format. This was fixed alongside the test rewrites.

Changes

File	Test	Action	Reason
create_work_item.rs	test_validation_rejects_short_title	Rewritten	Bare is_err() → unwrap_err() + "title must be more than 5 characters"
create_work_item.rs	test_validation_rejects_short_description	Rewritten	Bare is_err() → unwrap_err() + "description must be more than 30 characters"
create_work_item.rs	test_validation_rejects_tag_with_semicolon	Rewritten	Bare is_err() → unwrap_err() + "semicolon"
create_work_item.rs	CreateWorkItemParams::validate()	Implementation fix	Added descriptive messages to the two bare ensure!() calls so tests have something meaningful to assert
update_work_item.rs	test_params_validates_title_length	Rewritten	Bare is_err() → unwrap_err() + "255 characters or fewer"

Verification

• cargo test: all tests pass ✅
• cargo check: clean ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · 100.5 AIC · ⌖ 12 AIC · ⊞ 8.7K · ◷