docs: fix inaccurate compile-time permissions.write validation claim in debug prompt#1617
Merged
jamesadevine merged 1 commit intoJul 21, 2026
Conversation
…in debug prompt The debug prompt stated the compiler validates that permissions.write is set when write-bearing safe outputs are configured. This is incorrect: the compiler emits a valid pipeline regardless, defaulting to $(System.AccessToken) for the Stage 3 write token. No compile-time check exists for this condition. Verified in src/compile/common.rs (generate_acquire_ado_token returns empty when no service connection is given) and src/compile/agentic_pipeline.rs (no permissions.write validation). The executor simply falls back to the pipeline's default build identity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
marked this pull request as ready for review
July 21, 2026 19:23
jamesadevine
deleted the
docs/fix-permissions-debug-prompt-816220f762261c10
branch
July 21, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Documentation Update
Findings
prompts/debug-ado-agentic-workflow.mdclaimed the compiler validates thatpermissions.writeis set when write-bearing safe outputs are configured. No such compile-time check exists.prompts/debug-ado-agentic-workflow.mdApplied Fixes
$(System.AccessToken)for Stage 3. Permission failures are purely a runtime concern.Notes
Verified against:
src/compile/common.rs—generate_acquire_ado_tokenreturns an empty string (no script step) whenservice_connectionisNone, with no error or warning.src/compile/agentic_pipeline.rs— no validation that checks for a missingpermissions.writewhen safe outputs are present.src/compile/agentic_pipeline.rs(line 196+) /common.rsline 1811 — confirms$(System.AccessToken)is the hardcoded default fallback for the Stage 3 write token.The create prompt (
prompts/create-ado-agentic-workflow.md) already stated the correct behavior: "The compiler no longer requirespermissions.writefor write-bearing safe outputs — the executor defaults to$(System.AccessToken)." The debug prompt contradicted this with a claim that could mislead an agent into thinking a recompile would fix a runtime permission failure.Created by the agent-documentation maintainer workflow.