Skip to content

docs: fix inaccurate compile-time permissions.write validation claim in debug prompt#1617

Merged
jamesadevine merged 1 commit into
mainfrom
docs/fix-permissions-debug-prompt-816220f762261c10
Jul 21, 2026
Merged

docs: fix inaccurate compile-time permissions.write validation claim in debug prompt#1617
jamesadevine merged 1 commit into
mainfrom
docs/fix-permissions-debug-prompt-816220f762261c10

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Agent Documentation Update

Findings

Area Issue File(s)
accuracy prompts/debug-ado-agentic-workflow.md claimed the compiler validates that permissions.write is set when write-bearing safe outputs are configured. No such compile-time check exists. prompts/debug-ado-agentic-workflow.md

Applied Fixes

  • Replaced the incorrect "Compile-time validation" bullet (which falsely told agents to "recompile to fix this") with an accurate statement: the compiler emits a valid pipeline regardless, defaulting to $(System.AccessToken) for Stage 3. Permission failures are purely a runtime concern.

Notes

Verified against:

  • src/compile/common.rsgenerate_acquire_ado_token returns an empty string (no script step) when service_connection is None, with no error or warning.
  • src/compile/agentic_pipeline.rs — no validation that checks for a missing permissions.write when safe outputs are present.
  • src/compile/agentic_pipeline.rs (line 196+) / common.rs line 1811 — confirms $(System.AccessToken) is the hardcoded default fallback for the Stage 3 write token.

The create prompt (prompts/create-ado-agentic-workflow.md) already stated the correct behavior: "The compiler no longer requires permissions.write for write-bearing safe outputs — the executor defaults to $(System.AccessToken)." The debug prompt contradicted this with a claim that could mislead an agent into thinking a recompile would fix a runtime permission failure.


Created by the agent-documentation maintainer workflow.

Generated by Agent Documentation Maintainer · 171.4 AIC · ⌖ 11.9 AIC · ⊞ 8.7K ·

…in debug prompt

The debug prompt stated the compiler validates that permissions.write is set
when write-bearing safe outputs are configured. This is incorrect: the compiler
emits a valid pipeline regardless, defaulting to $(System.AccessToken) for the
Stage 3 write token. No compile-time check exists for this condition.

Verified in src/compile/common.rs (generate_acquire_ado_token returns empty when
no service connection is given) and src/compile/agentic_pipeline.rs (no
permissions.write validation). The executor simply falls back to the pipeline's
default build identity.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine
jamesadevine marked this pull request as ready for review July 21, 2026 19:23
@jamesadevine
jamesadevine merged commit 5ff9af6 into main Jul 21, 2026
3 of 5 checks passed
@jamesadevine
jamesadevine deleted the docs/fix-permissions-debug-prompt-816220f762261c10 branch July 21, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant