feat(tools): allow Azure DevOps MCP version override - #1843
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5571fe7-43c1-4358-adf3-edc4740ac633
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jamesadevine
added a commit
that referenced
this pull request
Aug 11, 2026
CI caught three assertions that still expected shell values interpolated inline. The PR moves them into the generated binding prelude, so the emitted text legitimately changed: * `tests/compiler_tests.rs` — the Azure DevOps MCP version (from #1843) now renders as `MCP_VERSION='2.9.0'` with `"$MCP_PACKAGE@$MCP_VERSION"` rather than `"@azure-devops/mcp@2.9.0"`. Both the override and default cases now assert on the prelude *and* the use, which also proves the install and its verification read one version rather than two. * `tests/gate_e2e.rs` — `find_gate_spec` located the gate step by the literal `node '<path>'`. With the path bound, that matched nothing and the test reported the gate as absent rather than as changed. Also passes `SYSTEMROOT` through the gate harness's `env_clear` on Windows. Node aborts during initialisation without it — its CSPRNG seeding resolves the OS crypto provider relative to that variable — and the failure surfaces as an assertion with empty stdout and a native stack trace, which reads like a gate-logic bug. Linux CI never hit this; it made the test unrunnable locally, which is how the stale locator survived review in the first place. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa46b482-6121-45e2-8278-1a9465b4f73e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools.azure-devops.versionoverride while retaining the compiler-pinned defaultrepositoriesandwork-itemsAddresses #1721.
Test plan
cargo test --bin ado-aw semantic_version --quietcargo test --bin ado-aw azure_devops --quietcargo test --bin ado-aw ado_mcp --quietcargo test --bin ado-aw tools_union_allow_arrays_and_consumer_scalars_win --quietcargo test --bin ado-aw versions_catalog --quietcargo test --test compiler_tests azure_devops_mcp --quietcargo clippy --quiet --all-targets