fix: sha256sum --ignore-missing silently passes when binary is absent from checksums.txt#47
Merged
jamesadevine merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
… binary name Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sha256sum silent pass issue with missing entries
fix: sha256sum --ignore-missing silently passes when binary is absent from checksums.txt
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sha256sum -c checksums.txt --ignore-missingexits 0 when every file listed inchecksums.txtis absent from disk — meaning if the downloaded binary name doesn't appear in the checksum file at all, verification silently succeeds and a swapped/corrupted binary passes undetected.Changes
templates/base.yml— Replace all 5 checksum verification lines (3×ado-aw-linux-x64, 2×awf-linux-x64) with a targeted grep-pipe approachtemplates/1es-base.yml— Same fix for 3×ado-aw-linux-x64download stepstests/compiler_tests.rs— Update assertion to verify the new pattern is present and the old--ignore-missingpattern is absentBefore / After
grepreturning exit 1 on a missing entry propagates as a pipeline failure, eliminating the silent-pass vulnerability. Same pattern applied toawf-linux-x64downloads.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.github.com (HTTP Only)/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow api.github.com /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/async_trait-0d9946b44b5e2a43.a/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-12332330a3699062.0tq789a8vmenn07qp0vvf0dwx.05hgysj.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/async_trait-0d9946b44b5e2a43.a/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-12332330a3699062.0tzcushkpgwxcr6sv53al5k17.05hgysj.rcgu.o 31r0dix20kr3skbjuuiyfs9p.1rv36bt.rcgu.o f983stzxmcqm183e5fj80tdk.1rv36bt.rcgu.o g17sk3czgm48iabfal8dyx7h.1rv36bt.rcgu.o ldwcgqf6z6ca1erbqvnm55pb.1rv36bt.rcgu.o q7ni8a30k6p3i4cy1i2iz51d.1rv36bt.rcgu.o sbrhf1x2sgxffk8b8hd1llvu.1rv36bt.rcgu.o 6we6jx0bkgt3jcjli55d5bvt.1rv36bt.rcgu.o 9p24xt9ayuj3yew22soxmrof.1rv36bt.rcgu.o jqq7gsagtt1mmt21cgtf29rq.1rv36bt.rcgu.o pwq4ph85phzpwz3x7nqops16.1rv36bt.rcgu.o rx69uilathex2942d9y10pla.1rv36bt.rcgu.o tn2jiuz7zzj48ogq61benz0o.1rv36bt.rcgu.o 77xkoqd5bwrczxu1godtun7e.1rv36bt.rcgu.o ggbp88eaerqa2hprceyhcpyc.1rv36bt.rcgu.o(packet block)dev.azure.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow api.github.com --allow dev.azure.com --allow *.visualstudio.com g17sk3czgm48iabfal8dyx7h.1rv36bt.rcgu.o ldwcgqf6z6ca1erbqvnm55pb.1rv36bt.rcgu.o q7ni8a30k6p3i4cy1i2iz51d.1rv36bt.rcgu.o sbrhf1x2sgxffk8b8hd1llvu.1rv36bt.rcgu.o 6we6jx0bkgt3jcjli55d5bvt.1rv36bt.rcgu.o 9p24xt9ayuj3yew22soxmrof.1rv36bt.rcgu.o jqq7gsagtt1mmt21cgtf29rq.1rv36bt.rcgu.o pwq4ph85phzpwz3x7nqops16.1rv36bt.rcgu.o rx69uilathex2942d9y10pla.1rv36bt.rcgu.o tn2jiuz7zzj48ogq61benz0o.1rv36bt.rcgu.o 77xkoqd5bwrczxu1godtun7e.1rv36bt.rcgu.o ggbp88eaerqa2hprceyhcpyc.1rv36bt.rcgu.o(dns block)msazuresphere.visualstudio.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow api.github.com --allow dev.azure.com --allow *.visualstudio.com g17sk3czgm48iabfal8dyx7h.1rv36bt.rcgu.o ldwcgqf6z6ca1erbqvnm55pb.1rv36bt.rcgu.o q7ni8a30k6p3i4cy1i2iz51d.1rv36bt.rcgu.o sbrhf1x2sgxffk8b8hd1llvu.1rv36bt.rcgu.o 6we6jx0bkgt3jcjli55d5bvt.1rv36bt.rcgu.o 9p24xt9ayuj3yew22soxmrof.1rv36bt.rcgu.o jqq7gsagtt1mmt21cgtf29rq.1rv36bt.rcgu.o pwq4ph85phzpwz3x7nqops16.1rv36bt.rcgu.o rx69uilathex2942d9y10pla.1rv36bt.rcgu.o tn2jiuz7zzj48ogq61benz0o.1rv36bt.rcgu.o 77xkoqd5bwrczxu1godtun7e.1rv36bt.rcgu.o ggbp88eaerqa2hprceyhcpyc.1rv36bt.rcgu.o(dns block)raw.github.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw /home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw proxy --allow *.github.com embed-bitcode=no -C debuginfo=2 --cfg feature="default" --cfg feature="std" --check-cfg lib/�� 759b226da/rustcO/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/schemars_derive-486665cf5f9386cc 759b226da/build_/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/schemars_derive-486665cf5f9386-m64 lib/rustlib/x86_64-REDACTED-linux-gnu/bin/gcc-ld/ld.lld lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc lib/rustlib/x86_--crate-name lib/rustlib/x86_terminal_size lib/rustlib/x86_--edition=2021(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.