Skip to content

fix: sha256sum --ignore-missing silently passes when binary is absent from checksums.txt #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 2 commits into from
Mar 17, 2026
Merged

fix: sha256sum --ignore-missing silently passes when binary is absent from checksums.txt #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b97b24
Initial plan
Copilot Mar 17, 2026
a81f71d
fix: sha256sum --ignore-missing silently passes when no entry matches…
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/1es-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ extends:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -
mv ado-aw-linux-x64 ado-aw
chmod +x ado-aw
displayName: "Download agentic pipeline compiler (v{{ compiler_version }})"
Expand Down Expand Up @@ -182,7 +182,7 @@ extends:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -
mv ado-aw-linux-x64 ado-aw
chmod +x ado-aw
displayName: "Download agentic pipeline compiler (v{{ compiler_version }})"
Expand Down Expand Up @@ -327,7 +327,7 @@ extends:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -
mv ado-aw-linux-x64 ado-aw
chmod +x ado-aw
displayName: "Download agentic pipeline compiler (v{{ compiler_version }})"
Expand Down
10 changes: 5 additions & 5 deletions templates/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -
mv ado-aw-linux-x64 ado-aw
chmod +x ado-aw
displayName: "Download agentic pipeline compiler (v{{ compiler_version }})"
Expand Down Expand Up @@ -185,7 +185,7 @@ jobs:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "awf-linux-x64" checksums.txt | sha256sum -c -
mv awf-linux-x64 awf
chmod +x awf
echo "##vso[task.prependpath]$(Pipeline.Workspace)/awf"
Expand Down Expand Up @@ -325,7 +325,7 @@ jobs:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -
mv ado-aw-linux-x64 ado-aw
chmod +x ado-aw
displayName: "Download agentic pipeline compiler (v{{ compiler_version }})"
Expand All @@ -346,7 +346,7 @@ jobs:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "awf-linux-x64" checksums.txt | sha256sum -c -
mv awf-linux-x64 awf
chmod +x awf
echo "##vso[task.prependpath]$(Pipeline.Workspace)/awf"
Expand Down Expand Up @@ -523,7 +523,7 @@ jobs:

echo "Verifying checksum..."
cd "$DOWNLOAD_DIR"
sha256sum -c checksums.txt --ignore-missing
grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -
mv ado-aw-linux-x64 ado-aw
chmod +x ado-aw
displayName: "Download agentic pipeline compiler (v{{ compiler_version }})"
Expand Down
8 changes: 6 additions & 2 deletions tests/compiler_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,12 @@ fn test_compiled_yaml_structure() {
"Template should download the compiler from GitHub Releases"
);
assert!(
template_content.contains("sha256sum -c checksums.txt --ignore-missing"),
"Template should verify checksum using checksums.txt"
!template_content.contains("sha256sum -c checksums.txt --ignore-missing"),
"Template should not use --ignore-missing which silently passes when binary is missing from checksums"
);
assert!(
template_content.contains(r#"grep "ado-aw-linux-x64" checksums.txt | sha256sum -c -"#),
"Template should verify ado-aw checksum using targeted grep to ensure binary entry exists"
);

// Verify AWF (Agentic Workflow Firewall) is downloaded from GitHub Releases, not ADO pipeline artifacts
Expand Down
Loading