test: fix vacuous assertions in audit analyzer tests

[github-actions]

Test Suite Reduction: src/audit/analyzers/otel.rs + src/audit/analyzers/missing.rs

What was wrong

• analyze_otel_reads_otel_only (otel.rs): The assertion assert_eq!(analysis.metrics.effective_tokens, analysis.metrics.token_usage) is vacuous. In the implementation both fields are unconditionally set to the same total_tokens value, so the comparison is structurally equivalent to assert_eq!(x, x) — it can never fail and provides no regression protection. Separately, assert!(analysis.metrics.turns > 0) would pass even if the fixture only produced 1 turn instead of the expected 2.

• mixed_ndjson_file_filters_each_signal_and_ignores_unrelated_entries (missing.rs): The assertion assert!(noops.iter().all(|report| report.tool.is_none())) is vacuous. extract_noops unconditionally sets tool: None on every NoopReport it constructs — the assertion is tautologically true regardless of the input data and can never expose a regression.

Changes

File	Test	Action	Reason
otel.rs	analyze_otel_reads_otel_only	Rewritten	Replaced self-referential field comparison with pinned token count from fixture (33 185) and exact turn count (2)
missing.rs	mixed_ndjson_file_filters_each_signal_and_ignores_unrelated_entries	Rewritten	Replaced always-true tool.is_none() loop with assertions on noop context values and the description→reason fallback path

Verification

• cargo test: all 1 761 unit + 135 integration tests pass ✅
• cargo clippy --all-targets --all-features: no warnings ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com
• spsprodweu4.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"
    - "spsprodweu4.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · sonnet46 2.9M · ◷