Skip to content

Fix workshop reader accessibility semantics and QA screenshot publishing#1741

Merged
pelikhan merged 5 commits into
mainfrom
copilot/workshop-playwright-qa-fix-accessibility-issues
Jul 21, 2026
Merged

Fix workshop reader accessibility semantics and QA screenshot publishing#1741
pelikhan merged 5 commits into
mainfrom
copilot/workshop-playwright-qa-fix-accessibility-issues

Conversation

Copilot AI commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The workshop single-page reader rendered no top-level heading, skipped heading levels by promoting page titles to <h4> inside <summary>, and emitted task-list checkboxes without accessible names. The Playwright QA workflow also referenced local screenshot paths instead of publishing embeddable assets in issues.

  • Reader heading semantics

    • Render each workshop page title as a visible page-level <h1> instead of a <h4> in the disclosure summary.
    • Keep the disclosure summary non-visual so the reader retains page-switching behavior without polluting the heading outline.
    • Preserve valid heading progression across each rendered workshop section.
  • Task list accessibility

    • Derive an accessible name from each checklist item’s rendered text.
    • Apply that text as aria-label on generated task-list checkboxes.
  • HTML safety

    • Centralize text flattening/escaping for generated heading and checkbox attributes to avoid unsafe interpolation.
  • QA workflow screenshot assets

    • Add upload-asset safe output to the Playwright QA workflow.
    • Update the workflow prompt so each finding uploads its screenshot and embeds the returned asset URL directly in the issue/comment body.

Example of the generated checkbox markup after this change:

<li class="task-list-item">
  <input
    class="task-list-item-checkbox"
    disabled=""
    type="checkbox"
    aria-label="You have a GitHub account with access to GitHub Codespaces">
  You have a GitHub account with access to GitHub Codespaces
</li>

Copilot AI and others added 3 commits July 21, 2026 08:00
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix accessibility issues for workshop pages Fix workshop reader accessibility semantics and QA screenshot publishing Jul 21, 2026
Copilot AI requested a review from pelikhan July 21, 2026 08:05
@pelikhan
pelikhan marked this pull request as ready for review July 21, 2026 08:07
@pelikhan
pelikhan merged commit 4c19c26 into main Jul 21, 2026
4 checks passed
@pelikhan
pelikhan deleted the copilot/workshop-playwright-qa-fix-accessibility-issues branch July 21, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[workshop-playwright-qa] __root__: 3 QA finding(s) — accessibility

2 participants