Prevent duplicate workshop-page view transitions during hash navigation - #2386
Merged
pelikhan merged 2 commits intoJul 30, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix navigation JS error on workshop pages
Prevent duplicate Jul 30, 2026
workshop-page view transitions during hash navigation
pelikhan
marked this pull request as ready for review
July 30, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash-based navigation could open nested
<details>before switching the active workshop page, briefly creating an invalid transition state with duplicateview-transition-name: workshop-page. This triggered aborted View Transitions and console errors across workshop pages.Runtime navigation ordering
scripts/lib/page-template.jsso page switching (showWorkshopPage) happens before expanding nested details (openDetailsAncestors) for non-page anchors.hashchangehandling and in-page hash-link click handling.Regression coverage
scripts/build-docs.test.jsto assert the new call order in generated output for both navigation paths.Illustrative change