Skip to content

Fix workshop page gutters and interactive target sizing - #2490

Merged
pelikhan merged 2 commits into
mainfrom
copilot/workshop-playwright-qa-fix-qa-findings
Aug 4, 2026
Merged

Fix workshop page gutters and interactive target sizing#2490
pelikhan merged 2 commits into
mainfrom
copilot/workshop-playwright-qa-fix-qa-findings

Conversation

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The rendered workshop page used a 16px mobile gutter because Primer’s .px-3 utility overrode the intended .markdown-body padding. Several rendered links and <summary> controls also measured below the 44×44px interaction target requirement.

  • Responsive gutters

    • Ensures .markdown-body keeps at least a 20px inline gutter below 480px.
    • Preserves existing wider breakpoint gutters while overriding Primer utility padding.
  • Interactive targets

    • Adds 44px minimum target sizing for visible body links, nested summaries, workshop nav buttons, side-menu links, and the footer link.
    • Uses inline-flex alignment so text links keep their visual style while gaining accessible hit area.
  • Regression coverage

    • Extends docs build tests to assert the emitted gutter and target-size CSS.
.markdown-body {
  padding-inline: 20px !important;
}

.markdown-body a:not(.anchor):not(.workshop-nav-btn),
.workshop-navigation a:not(.anchor):not(.workshop-nav-btn) {
  display: inline-flex;
  align-items: center;
  min-width: 44px;
  min-height: 44px;
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix QA findings for brand and accessibility on multiple viewports Fix workshop page gutters and interactive target sizing Aug 4, 2026
Copilot AI requested a review from pelikhan August 4, 2026 12:48
@pelikhan
pelikhan marked this pull request as ready for review August 4, 2026 12:48
@pelikhan
pelikhan merged commit f801b52 into main Aug 4, 2026
@pelikhan
pelikhan deleted the copilot/workshop-playwright-qa-fix-qa-findings branch August 4, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[workshop-playwright-qa] __root__: 2 QA findings — brand, accessibility

2 participants