fix: drop cached forge clients on app reset#3071
Merged
Merged
Conversation
Resetting the app wiped accounts but left authenticated Octokit clients cached in memory. Clear per-account forge client state on reset, mirroring removeAccount.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the TanStack Query / store refactor, "Reset App" wiped accounts and the query cache but left authenticated Octokit clients cached in memory (v6 cleared them via
clearOctokitClientCacheinAppContext, and that call was dropped in the migration).reset()now drops per-account forge client state the same wayremoveAccountalready does, so no token-bearing clients outlive a reset.