perf(notifications): refresh enriched details when window regains focus - #3118
Merged
Conversation
…nt-on-window-focus # Conflicts: # src/renderer/hooks/useNotifications.test.tsx
|
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow-up to #3102, implementing the approach proposed in #3102 (comment).
Problem
The enrichment cache introduced in #3102 is keyed by
account:id:updatedAt, and some subject changes (labels, milestones, reactions) never bump a notification'supdatedAt. Those details can therefore drift while the app polls in the background, with nothing to invalidate them until the thread next has real activity.Change
Bust the enrichment cache when the Gitify window regains focus, so:
Implementation:
refreshEnrichmentCache(throttleMs)clears the cache and reports whether it did, throttled so rapid window open/close cycles cost at most one extra enrichment pass per throttle window (the fetch interval).focusManager(the same signal that already drivesrefetchOnWindowFocus) and, when the cache was actually cleared, triggers an explicitrefetch(). The explicit refetch matters because the built-in focus refetch is stale-gated (30sstaleTimeagainst a 60s default poll), so roughly half of focus events would otherwise not re-enrich until the next poll; when both fire, TanStack dedupes the concurrent fetches.Tests
notifications.test.ts: fake-timer coverage for clear, throttle, and throttle expiry.useNotifications.test.tsx: the side-effects host refreshes on window focus with the configured interval; plain consumers do not.