feat: merge open and draft interfaces

[zyd123-cmd]

前端修改-只调用open状态的接口 后端会一起返回open和draft的cl数据

[github-actions]

Claude finished @zyd123-cmd's task in 1m 44s —— View job

---

Code Review

• Gather PR context and changed files
• Read and analyze moon/apps/web/components/ClView/index.tsx
• Read and analyze moon/packages/types/generated.ts
• Finalize and post review

---

Summary: This PR simplifies the CL list frontend by removing the dual-fetch logic (separate calls for open and draft) in favor of a single API call, relying on the backend to return combined open + draft data when status: 'open' is passed. The overall direction is a good simplification — removing ~86 lines of net code. Below are the findings.

---

moon/apps/web/components/ClView/index.tsx

Bug: Missing draft case in getDescription [Medium]

Since the open tab now returns both open and draft items from the backend, draft CLs will be rendered in the list — but getDescription has no case for 'draft', falling through to default: return null. This means draft items will silently show no description.

// index.tsx:259 - no 'draft' case
default:
  return null

A draft case should be added similar to the open case. Fix this →

---

Dead Code: useDraftClList.ts hook file remains

The import of useDraftClList was removed from index.tsx, but moon/apps/web/components/ClView/hook/useDraftClList.ts still exists. If no other component uses this hook, it should be deleted to prevent confusion. Fix this →

---

ESLint Suppression on useEffect deps [Low]

// index.tsx:132-135
useEffect(() => {
  fetchClListData()
  // eslint-disable-next-line react-hooks/exhaustive-deps
}, [page, pageSize, status])

The comment intentionally excludes fetchClListData from the dependency array. Since fetchClListData is wrapped in useCallback with [page, pageSize, status, fetchClList], these deps overlap. The suppression is functional in practice, but it would be cleaner to either:

• Include fetchClListData in the deps (the fully correct approach), or
• Document why it's intentionally excluded

---

any type for additional payload [Low]

// index.tsx:105
const additional: any = { ... }

Using any loses type safety. The PageParamsListPayload['additional'] type (or a defined interface) would be preferable here, matching what the API actually expects.

---

moon/packages/types/generated.ts

This is an auto-generated file. The changes appear to be a regeneration from an updated API spec, which is the correct approach. A few observations:

Unrelated changes bundled in this PR [Low]

The following changes appear unrelated to the CL open/draft merge feature and are mixed into this PR:

• New from_hash / repo_path fields in CommonResultCompleteResponse and CompleteResponse
• New CommonResultCreateEntryResult and CreateEntryResult types
• mode?: EditCLMode and skip_build?: boolean added to CreateEntryInfo
• PostApiCreateEntryData changed from CommonResultString → CommonResultCreateEntryResult (breaking return type change)
• trigger_type comment update adding buck_file_upload

These look like legitimate API spec changes, but bundling unrelated type changes with the CL feature change makes it harder to review and bisect if regressions occur. Consider splitting if possible.

PostApiCreateEntryData return type change [Medium]

// Before:
export type PostApiCreateEntryData = CommonResultString
// After:
export type PostApiCreateEntryData = CommonResultCreateEntryResult

This is a breaking change in the API return type. Any callers of the "create entry" API that currently expect a string in data will now receive an object. Please verify all call sites have been updated accordingly.

---

Overall Assessment

Area	Status
Code simplification	✅ Good — logic significantly simplified
Bug: draft description missing	⚠️ Needs fix
Dead code cleanup	⚠️ useDraftClList.ts not deleted
Type safety	⚠️ any usage
Breaking type change	⚠️ Verify call sites for PostApiCreateEntryData
Tests	ℹ️ No tests added/modified

The core logic change is sound. The main concerns are the missing draft case in getDescription (which would silently hide descriptions for draft CLs on the open tab) and verifying nothing is broken by the PostApiCreateEntryData type change.

[genedna]

@codex review

[Copilot]

Pull request overview

This PR consolidates the frontend CL (Change List) fetching logic by merging the separate open and draft API calls into a single endpoint. The backend now returns both open and draft CLs when status='open' is requested, eliminating the need for dual API calls and complex race condition handling on the frontend.

Changes:

• Updated TypeScript generated types to include new API response fields (from_hash, repo_path, CreateEntryResult, EditCLMode, skip_build)
• Simplified ClView component by removing useDraftClList hook and the complex dual-fetch logic with race condition handling
• Changed API response type for PostApiCreateEntryData from CommonResultString to CommonResultCreateEntryResult

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
moon/packages/types/generated.ts	Added new fields to CompleteResponse and CommonResultCompleteResponse (from_hash, repo_path); introduced CreateEntryResult type and updated PostApiCreateEntryData response type; added EditCLMode and skip_build support for CreateEntryInfo; updated trigger type documentation
moon/apps/web/components/ClView/index.tsx	Removed useDraftClList hook import and usage; simplified fetchClListData to make single API call instead of dual open+draft calls; removed complex finalize() logic that handled race conditions between two parallel requests; updated useEffect dependency array

[Copilot]

The useEffect dependency array is missing fetchClListData which is used inside the effect. While you've disabled the exhaustive-deps lint rule, this creates a potential issue: if fetchClList changes (which is included in fetchClListData's dependencies), the effect won't re-run but fetchClListData will capture a stale closure of fetchClList.

Either:

1. Add fetchClListData to the dependency array (recommended), or
2. If you intentionally want to avoid re-running when fetchClList changes, document why with a comment explaining the reasoning

Suggested change

	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [page, pageSize, status])
	}, [fetchClListData])

[Copilot]

The import statement for useDraftClList has been removed, but the hook file itself (moon/apps/web/components/ClView/hook/useDraftClList.ts) likely still exists in the codebase. Since this hook is no longer used anywhere (verified via search), the file should be deleted to avoid confusion and maintain a clean codebase.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".