fix: Temporarily do not block the merge process when check fails. #2009
Conversation
Signed-off-by: Ruizhi Huang <231220075@smail.nju.edu.cn>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/web3infra-foundation/mega/blob/b5a5a0467197e8d32e64462b77c5ce9b31d2b459/ceres/src/api_service/mono_api_service.rs#L3560-L3561
execute_merge_workflow now proceeds from conflict checking to merge without validating required check results, so queued merges can land changes even when required checks are FAILED. Since this path drives automated queue processing, it allows policy bypass at scale rather than only for a one-off manual override.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .await | ||
| .map_err(|e| GitError::CustomError(e.to_string()))?; | ||
|
|
||
| self.merge_cl_unchecked(username, cl).await |
There was a problem hiding this comment.
merge_cl now calls merge_cl_unchecked immediately after the ref-hash check, so /cl/{link}/merge can merge CLs even when required checks (e.g., CodeReview/CLA/CI) are failing or stale because the previous ensure_cl_mergeable validation was removed in this commit. This weakens merge protections for all interactive merges, not just the temporary failure path.
Useful? React with 👍 / 👎.
2 participants
No description provided.