Fix/orion changes unify#2048
Conversation
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
Signed-off-by: jackieismpc <jackieismpc@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fd858cb7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let use_direct_connection = base_url.starts_with("http://127.0.0.1") | ||
| || base_url.starts_with("https://127.0.0.1") | ||
| || base_url.starts_with("http://localhost") | ||
| || base_url.starts_with("https://localhost") |
There was a problem hiding this comment.
The localhost detection uses raw starts_with checks on the full URL string, so non-loopback hosts like http://localhost.example.com (or any URL whose prefix matches these literals) will be treated as local and force no_proxy(). In environments where outbound traffic must go through a proxy, this misclassification can break build dispatch to Orion by bypassing the configured proxy unexpectedly. Please parse base_url as a URL and compare only the hostname against exact loopback values (localhost, 127.0.0.1, ::1).
Useful? React with 👍 / 👎.
2 participants
1.add more tests for ceres->orion-server->orion
2.fix some bugs