Skip to content

Fix certificate alert to add more debug and use ask handle#11141

Merged
roboquat merged 1 commit into
mainfrom
ljb/fix-cert-error-debug-and-alert
Jul 5, 2022
Merged

Fix certificate alert to add more debug and use ask handle#11141
roboquat merged 1 commit into
mainfrom
ljb/fix-cert-error-debug-and-alert

Conversation

@liam-j-bennett

Copy link
Copy Markdown
Contributor

Description

Updates the certificate failure alerts to provide more debug and use @ask-platform handle

Release Notes

NONE

Werft options:

  • /werft with-preview

@liam-j-bennett

liam-j-bennett commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Seems like some auto linting on this happened, so it might be a bit more annoying to see the changes 😭

@meysholdt

meysholdt commented Jul 5, 2022

Copy link
Copy Markdown
Member

Seems like some auto linting on this happened, so it might be a bit more annoying to see the changes 😭

indeed. We may want to lint 'em all.

@meysholdt

Copy link
Copy Markdown
Member

Hey @liam-j-bennett, could you rebase this PR? The .ts files are formatted now: #11142. Not sure how good git is at doing this rebase or if it's easier to hand-pick the few lines that you changed in this PR. Apologies for the trouble, but in this way we solve the formatting pain once-and-for-all and also get a pleasant review experience for this PR.

@liam-j-bennett
liam-j-bennett force-pushed the ljb/fix-cert-error-debug-and-alert branch from 8c49cb8 to 8b1ad96 Compare July 5, 2022 12:44
@roboquat roboquat added size/S and removed size/L labels Jul 5, 2022
@roboquat
roboquat merged commit b534807 into main Jul 5, 2022
@roboquat
roboquat deleted the ljb/fix-cert-error-debug-and-alert branch July 5, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants