Retry the finalizer loop when the ws-daemon pod not found#11563
Merged
Conversation
jenting
force-pushed
the
jenting/connect-to-ws-daemon-when-needed
branch
from
July 22, 2022 15:23
918e24d to
f202131
Compare
jenting
force-pushed
the
jenting/connect-to-ws-daemon-when-needed
branch
from
July 22, 2022 16:17
f202131 to
5124134
Compare
jenting
force-pushed
the
jenting/connect-to-ws-daemon-when-needed
branch
from
July 22, 2022 16:39
5124134 to
3c110b5
Compare
jenting
force-pushed
the
jenting/connect-to-ws-daemon-when-needed
branch
2 times, most recently
from
July 22, 2022 23:00
be8e5f1 to
30dfd0f
Compare
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
jenting
force-pushed
the
jenting/connect-to-ws-daemon-when-needed
branch
from
July 25, 2022 01:53
30dfd0f to
444ccf0
Compare
jenting
marked this pull request as ready for review
July 25, 2022 03:22
utam0k
reviewed
Jul 26, 2022
utam0k
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retry the function
doFinalizewhen the ws-daemon pod is not found so that we can reach the conditiongitpod/components/ws-manager/pkg/manager/monitor.go
Lines 1272 to 1278 in 444ccf0
Related Issue(s)
Fixes #10682
How to test
dd if=/dev/urandom of=4G bs=16M count=256Gitpod: stop workspaceand immediately go to step 5.while true; do kubectl delete pod -l component=ws-daemon; doneRelease Notes
Documentation
None
Werft options: