[install/infra] Fixup k3s database unique IDs, GKE unique ID syntax, EKS long branch name IAM role errors#12321
Merged
Conversation
…suffix EKS limits [iam role prefix lengths] to 38 characters, as the IAM role length max is 64 characters and the random 26 character suffix eats up most of the string length. As we're naming our clusters based on the current branch these names could become quite long. This commit removes this issue by creating a specific IAM role name and creating our own unique IDs. [iam role prefix lengths]: https://github.com/hashicorp/terraform-provider-aws/blob/v4.27.0/internal/service/iam/role.go#L29-L30
github-actions
Bot
added
the
team: delivery
Contributor
Author
|
/release-note-none |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
nandajavarma
approved these changes
Aug 24, 2022
nandajavarma
left a comment
nandajavarma
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for making this changes Adrien! I only fixed it on GCP and missed on other clusters 🤦♀️
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.