Skip to content

Tune JB backend dev loop#12390

Merged
roboquat merged 4 commits into
mainfrom
ak/tune_jb_build
Sep 12, 2022
Merged

Tune JB backend dev loop#12390
roboquat merged 4 commits into
mainfrom
ak/tune_jb_build

Conversation

@akosyakov

@akosyakov akosyakov commented Aug 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

JB dev loop with preview env: from 25mins to 25sec - Watch Video

This PR introduces a new workspace layer to deliver JB plugin independent from JB backend. It reduces build times from 15mins to 5mins on changes in JB backend plugin, since it does not require rebuild of all variants of JB backend images.

First #12426 should be deployed by workspace and webapp teams and all users migrated to new clusters.

It also adds several dev time scripts allowing hot deployment, hot swapping and remote debugging. So one can directly adjust IDE configuration or a running workspace in preview environment without even committing changes.

gitpod-remote-hot drawio

Related Issue(s)

Related #12268

How to test

Start a workspace with:

  • IntellIJ IDEA stable and latest as default IDE from dashboard
  • GoLand stable and latest from JB Gateway while VS Code Browser is default IDE

How to verify that plugin version correspond to backend version (stable or latest)?

Screenshot 2022-08-26 at 11 33 56

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@akosyakov
akosyakov force-pushed the ak/tune_jb_build branch 2 times, most recently from 74d4901 to 8c87eac Compare August 25, 2022 14:38
@werft-gitpod-dev-com

werft-gitpod-dev-com Bot commented Aug 25, 2022

Copy link
Copy Markdown

started the job as gitpod-build-ak-tune-jb-build.5 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov akosyakov changed the title Ak/tune jb build Tune JB build Aug 26, 2022
@akosyakov akosyakov mentioned this pull request Aug 26, 2022
Merged
1 task
@akosyakov
akosyakov changed the base branch from main to ak/prepare_tune_jb_build August 26, 2022 07:24
@roboquat roboquat added size/XL and removed size/XXL labels Aug 26, 2022
@akosyakov
akosyakov marked this pull request as ready for review August 26, 2022 07:27
@akosyakov
akosyakov requested a review from a team August 26, 2022 07:27
@akosyakov

akosyakov commented Aug 26, 2022

Copy link
Copy Markdown
Member Author

/hold

First #12426 should be deployed by workspace and webapp teams and all users migrated to new clusters.

@akosyakov

akosyakov commented Aug 26, 2022 •
edited by werft-gitpod-dev-com Bot
Loading

Copy link
Copy Markdown
Member Author

/werft run

👍 started the job as gitpod-build-ak-tune-jb-build.9
(with .werft/ from main)

@akosyakov
akosyakov force-pushed the ak/tune_jb_build branch 8 times, most recently from c4ccfe9 to 1ba3ee6 Compare August 28, 2022 12:09
@akosyakov
akosyakov force-pushed the ak/tune_jb_build branch 2 times, most recently from 3b6e69b to c2ed6b0 Compare August 28, 2022 20:39
@akosyakov akosyakov changed the title Tune JB build Tune JB backend dev lopp Aug 28, 2022
@akosyakov akosyakov changed the title Tune JB backend dev lopp Tune JB backend dev loop Aug 28, 2022
filiptronicek
filiptronicek reviewed Aug 29, 2022
View reviewed changes
Comment thread components/ide/jetbrains/backend-plugin/README.md

### Remote debugging

Run `./remote-debug.sh <workspaceURL> (<localPort>)?` to configure remote debugging in a workpace running in preview environment.

@filiptronicek filiptronicek Aug 29, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(minor): spotted this one in the Loom you shared 😄

Suggested change
Run `./remote-debug.sh <workspaceURL> (<localPort>)?` to configure remote debugging in a workpace running in preview environment.
Run `./remote-debug.sh <workspaceURL> (<localPort>)?` to configure remote debugging in a workspace running in preview environment.

Base automatically changed from ak/prepare_tune_jb_build to main August 30, 2022 07:36
@roboquat
roboquat requested a review from a team August 30, 2022 07:36
@roboquat
roboquat requested a review from a team August 30, 2022 07:36
@roboquat
roboquat requested a review from csweichel as a code owner August 30, 2022 07:36
@github-actions github-actions Bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Aug 30, 2022
sagor999
sagor999 approved these changes Aug 30, 2022
View reviewed changes

@sagor999 sagor999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed workspace-team related changes. LGTM

easyCZ
easyCZ approved these changes Sep 1, 2022
View reviewed changes

@easyCZ easyCZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from WebApp side.

/hold in case you want another review

Worth noting that depending on the rollout ordering, we cannot guarantee that the server changes will be shipped before the plugin changes so some rollout management is needed from your side.

@github-actions

github-actions Bot commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@akosyakov

akosyakov commented Sep 12, 2022

Copy link
Copy Markdown
Member Author

/unhold

@roboquat
roboquat merged commit fcb426e into main Sep 12, 2022
@roboquat
roboquat deleted the ak/tune_jb_build branch September 12, 2022 09:21
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Sep 13, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiptronicek filiptronicek filiptronicek left review comments
@easyCZ easyCZ easyCZ approved these changes
@aledbf aledbf Awaiting requested review from aledbf
@csweichel csweichel Awaiting requested review from csweichel
+2 more reviewers
@andreafalzetti andreafalzetti andreafalzetti approved these changes
@sagor999 sagor999 sagor999 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XXL team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akosyakov @easyCZ @andreafalzetti @sagor999 @filiptronicek @roboquat