Clean up webhook events#12472
Conversation
|
started the job as gitpod-build-at-events-gc.1 because the annotations in the pull request description changed |
b9b51ac to
f798650
Compare
|
back to draft. just tested the query and |
f798650 to
847743e
Compare
|
I removed the problematic |
|
@geropl, maybe you want to have a look at this one? |
|
@AlexTugarev Will review now. |
by running a periodic garbage collector. This is a pattern we use for other resources. fixes #12430
847743e to
2a66cc5
Compare
|
/werft run 👍 started the job as gitpod-build-at-events-gc.5 |
|
build was failing for an unrelated issue with db-sync replication. restarted. |
|
/werft run 👍 started the job as gitpod-build-at-events-gc.6 |
geropl
left a comment
There was a problem hiding this comment.
Code LGTM, tested and saw the GC doing it's job. Thank you! 🎉
by running a periodic garbage collector. This is a pattern we use for other resources.
fixes #12430
Description
The way GC works is admittedly tricky, as it's an interplay between the periodic GC task and the
db-sync. Periodically this will mark a bunch of entries asdeleted, and we rely on thedb-syncto actually delete the entries.Because it's proven unreliable to mark entries as delete in the thousands, leaving them in the db for ever after a failure, the settings to mark as deleted periodically are: 600 entries every 6 minutes, which is a rate of ~200K/day and should not produce a lot of DB CPU usage.
Related Issue(s)
Fixes #12430
How to test
Release Notes
Documentation
Werft options: