Skip to content

PVC integration tests: TestBackup and TestRegularWorkspaceTasks and TestWorkspaceEnableAndDisablePVC#12620

Merged
roboquat merged 6 commits into
mainfrom
jenting/12497
Sep 5, 2022
Merged

PVC integration tests: TestBackup and TestRegularWorkspaceTasks and TestWorkspaceEnableAndDisablePVC#12620
roboquat merged 6 commits into
mainfrom
jenting/12497

Conversation

@jenting

@jenting jenting commented Sep 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add PVC feature flag to TestBackup

  • Create a fresh new workspace with Git initializer
  • Write a foobar.txt file
  • Stop the workspace
  • Recreate the workspace
  • Make sure the foobar.txt file exists

Add PVC feature flag to TestRegularWorkspaceTasks

  • Create a fresh new workspace with Git initializer and Gitpod tasks
  • Make sure each task generated file exists

Add PVC integration test to TestWorkspaceEnableAndDisablePVC

  • Open a fresh new workspace
  • Write a foobar.txt file
  • Stop the workspace
  • Relaunch the workspace with the PVC feature flag
  • Make sure the foobar.txt file exists
  • Stop the workspace
  • Relaunch the workspace without the PVC feature flag
  • Make sure the foobar.txt file exists

Related Issue(s)

#12497

How to test

cd test

go test  -run ^TestBackup$ github.com/gitpod-io/gitpod/test/tests/components/ws-manager -count=1 -namespace=default -kubeconfig=/home/gitpod/.kube/config -v

go test  -run ^TestRegularWorkspaceTasks$ github.com/gitpod-io/gitpod/test/tests/components/ws-manager -count=1 -namespace=default -kubeconfig=/home/gitpod/.kube/config -v

go test  -run ^TestWorkspaceEnableAndDisablePVC$ github.com/gitpod-io/gitpod/test/tests/components/ws-manager -count=1 -namespace=default -kubeconfig=/home/gitpod/.kube/config -v

Release Notes

None

Documentation

Werft options:

  • /werft with-preview

@jenting
jenting marked this pull request as ready for review September 2, 2022 14:25
@jenting
jenting requested a review from a team September 2, 2022 14:26
@github-actions github-actions Bot added the team: workspace Issue belongs to the Workspace team label Sep 2, 2022
@jenting jenting mentioned this pull request Sep 2, 2022
Closed
9 tasks
@jenting
workspace integration test: find volume snapshot by label selector
08e4bf2 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
workspace integration test: add PVC test within TestBackup
10a5d3a 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
integration test: add owner for image build request
b2453bb 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@roboquat roboquat added size/XL and removed size/L labels Sep 3, 2022
@jenting
workspace integration test: add PVC test within TestRegularWorkspaceT…
92fedd3 
…asks

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting changed the title PVC integration tests: TestBackup PVC integration tests: TestBackup and TestRegularWorkspaceTasks Sep 3, 2022
@jenting
workspace integration test: add TestWorkspaceEnableAndDisablePVC
35b22d1 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting changed the title PVC integration tests: TestBackup and TestRegularWorkspaceTasks PVC integration tests: TestBackup and TestRegularWorkspaceTasks and TestWorkspaceEnableAndDisablePVC Sep 3, 2022
utam0k
utam0k reviewed Sep 5, 2022
View reviewed changes
Comment thread test/pkg/integration/integration.go Outdated
@utam0k

utam0k commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Waiting for https://werft.gitpod-dev.com/job/gitpod-custom-jenting-12497.0

utam0k
utam0k reviewed Sep 5, 2022
View reviewed changes
Comment thread test/pkg/integration/integration.go Outdated
@utam0k

utam0k commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

@jenting I made a commend, but other things look good to me.

@jenting
workspace integration test: pass context to FindVolumeSnapshot
f58b4b9 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
utam0k
utam0k approved these changes Sep 5, 2022
View reviewed changes

@utam0k utam0k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roboquat
roboquat merged commit 06d501b into main Sep 5, 2022
@roboquat
roboquat deleted the jenting/12497 branch September 5, 2022 07:08
@jenting
jenting restored the jenting/12497 branch September 5, 2022 07:11
@jenting
jenting deleted the jenting/12497 branch September 5, 2022 07:11
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 7, 2022
@jenting jenting mentioned this pull request Sep 13, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@utam0k utam0k utam0k approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XL team: workspace Issue belongs to the Workspace team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenting @utam0k @roboquat