[usage] Remove old controller & report generator#12688
Merged
Merged
Conversation
easyCZ
force-pushed
the
mp/usage-remove-old-controller
branch
3 times, most recently
from
September 7, 2022 11:07
4d351d5 to
2aa0e6e
Compare
1 task
easyCZ
force-pushed
the
mp/usage-remove-old-controller
branch
from
September 8, 2022 07:12
2aa0e6e to
6a93271
Compare
easyCZ
force-pushed
the
mp/usage-remove-old-controller
branch
from
September 8, 2022 07:32
6a93271 to
3bcf804
Compare
easyCZ
marked this pull request as ready for review
September 8, 2022 07:36
easyCZ
commented
Sep 8, 2022
| now := time.Now().UTC() | ||
| hourAgo := now.Add(-1 * time.Hour) | ||
|
|
||
| reportUsageReconcileStarted() |
Member
Author
There was a problem hiding this comment.
Only change here is to re-use the metrics from the previous controller in the new one.
easyCZ
commented
Sep 8, 2022
|
|
||
| func filterByWorkspaceId(all []db.WorkspaceInstanceForUsage, workspaceID string) []db.WorkspaceInstanceForUsage { | ||
| result := []db.WorkspaceInstanceForUsage{} | ||
| var result []db.WorkspaceInstanceForUsage |
Member
Author
There was a problem hiding this comment.
Drive-by for best-practice of slice instantiation
svenefftinge
approved these changes
Sep 8, 2022
roboquat
added
deployed: webapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These are no longer needed.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: