Skip to content

Update dev/ssh-load-test and dev/changelog go mod versions#12703

Merged
roboquat merged 1 commit into
mainfrom
aa/upd-gomod
Sep 6, 2022
Merged

Update dev/ssh-load-test and dev/changelog go mod versions#12703
roboquat merged 1 commit into
mainfrom
aa/upd-gomod

Conversation

@vulkoingim

@vulkoingim vulkoingim commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Description

GOCACHE gets corrupted due to old package versions that are being built and put in the cache at some point.

I'm almost certain that this should solve the problem.

@gitpod-io/engineering-workspace how is the cache populated? Is it done during a prebuild step? And is there a way to clean it?

How to test

Open a workspace and run:

 go install github.com/gitpod-io/observability/installer@main

# sigs.k8s.io/json/internal/golang/encoding/json
../go/pkg/mod/sigs.k8s.io/json@v0.0.0-20220713155537-f223a00ba0e2/internal/golang/encoding/json/encode.go:158:16: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)

# github.com/google/btree
../go/pkg/mod/github.com/google/btree@v1.1.2/btree_generic.go:89:16: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)

This succeeds (takes a while):

GOCACHE=$(pwd)/cache go install -v github.com/gitpod-io/observability/installer@main

Release Notes

NONE

Werft options:

  • /werft with-preview

@vulkoingim

vulkoingim commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

/werft run

👍 started the job as gitpod-build-aa-upd-gomod.0
(with .werft/ from main)

@ArthurSens

ArthurSens commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

I'm not sure what is being changed here or exactly why this change is needed.

I'm almost certain that this should solve the problem.

If it doesn't, it should be fairly ok to revert the change, right? 🙂

Are you waiting for a response from team-workspace or just wants a rubber-stamp?

@vulkoingim

vulkoingim commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

I'm not sure what is being changed here or exactly why this change is needed.

I'm almost certain that this should solve the problem.

If it doesn't, it should be fairly ok to revert the change, right? 🙂

Are you waiting for a response from team-workspace or just wants a rubber-stamp?

There should be no need for a revert. Not sure why those weren't updated.

A ✅ should suffice. The question towards the ws team is more for me understanding how it's built.

@roboquat
roboquat merged commit 6b14c1e into main Sep 6, 2022
@roboquat
roboquat deleted the aa/upd-gomod branch September 6, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants