[UBP] Add server method to create a stripe customers for an individual user#12753
Merged
Conversation
added 2 commits
September 8, 2022 07:14
Implement `findCustomerByTeamId` and `findCustomerByUserId` in terms of this more general method.
Directly analogous to createOrUpdateStripeCustomerForTeam, the only difference is the metadata on the resulting Stripe customer.
|
started the job as gitpod-build-af-server-create-stripe-customer-for-user.6 because the annotations in the pull request description changed |
1 task
geropl
reviewed
Sep 8, 2022
|
|
||
| async createOrUpdateStripeCustomerForUser(ctx: TraceContext, currency: string): Promise<void> { | ||
| const user = this.checkAndBlockUser("createOrUpdateStripeCustomerForUser"); | ||
| await this.ensureStripeApiIsAllowed({ user }); |
geropl
reviewed
Sep 8, 2022
| } | ||
| } | ||
|
|
||
| async createOrUpdateStripeCustomerForUser(ctx: TraceContext, currency: string): Promise<void> { |
Member
There was a problem hiding this comment.
☁️ Originally I thought about merging these two methods on attributionId. But I think it makes sense to have them separate as they have different semantics around access rights etc.
geropl
approved these changes
Sep 8, 2022
geropl
left a comment
geropl
left a comment
Member
There was a problem hiding this comment.
Code LGTM, tested and works. ✔️
17 tasks
roboquat
added
deployed: webapp
This was referenced Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
createOrUpdateStripeCustomerForUsermethod toserverto allow the creation of Stripe customers for individual users. Previously we had only thecreateOrUpdateStripeCustomerForTeammethod which would create a Stripe customer for a Gitpod team.The only difference between the
createOrUpdateStripeCustomerForUserandcreateOrUpdateStripeCustomerForTeammethods is the metadata in the resulting Stripe customer object. For teams we store[teamId]: fooand for users we store[userId]: bar.Related Issue(s)
Part of #12685
How to test
Gitpodin the name.Release Notes
Documentation
Werft options: