[usage] Instantiate now after we've collected all usage data#12759
Merged
Conversation
github-actions
Bot
added
team: webapp
geropl
reviewed
Sep 8, 2022
| instances = append(instances, instancesWithUsageInDraft...) | ||
|
|
||
| // now has to be computed after we've collected all data, to ensure that it's always greater than any of the records we fetch | ||
| now := s.nowFunc() |
Member
There was a problem hiding this comment.
I think this might be an improvement and will fix ti.
☁️ Note that this alone is not a guarantee that startTimes are not greated than now in a distributed setting. But maybe reasonably safe to assume, yes.
roboquat
added
deployed: webapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the original case, we'd compute time as
t, but we'd then go fetch instances and possibly find ones which which only started running aftert. This would result innow - t.Started()to be negative, and hence negative runtimeRelated Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: