[dashboard] (pagination) make sure next page is selectable#12809
Merged
Conversation
andrew-farries
suggested changes
Sep 9, 2022
gtsiolis
approved these changes
Sep 9, 2022
gtsiolis
left a comment
gtsiolis
left a comment
Contributor
There was a problem hiding this comment.
Couldn't test this in a preview environment but from the tests added here UX looks great!
AlexTugarev
force-pushed
the
alex/usage-list-pagination-does-12804
branch
from
September 9, 2022 11:11
598278c to
956487c
Compare
Member
Author
|
@andrew-farries, please have a second look at it! |
Member
Author
|
/hold |
andrew-farries
approved these changes
Sep 9, 2022
|
started the job as gitpod-build-alex-usage-list-pagination-does-12804.2 because the annotations in the pull request description changed |
Member
Author
|
/hold cancel |
AlexTugarev
force-pushed
the
alex/usage-list-pagination-does-12804
branch
from
September 9, 2022 13:48
956487c to
4f8bee3
Compare
roboquat
added
deployed: webapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes pagination, where the page next to current was not selectable.
Related Issue(s)
Fixes #12804
How to test
Release Notes
Documentation
Werft options: