[UBP] Use findStripeSubscriptionId in BillingAccountSelector component#12954
Merged
Conversation
Use the more general `findStripeSubscriptionId` rather than `findStripeSubscriptionIdForTeam` to allow the latter to be safely removed from the server JSON-RPC API.
|
started the job as gitpod-build-af-use-find-stripe-subscription-id.2 because the annotations in the pull request description changed |
17 tasks
jankeromnes
approved these changes
Sep 14, 2022
2 tasks
roboquat
added
deployed: webapp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the more general
findStripeSubscriptionIdAPI rather thanfindStripeSubscriptionIdForTeamto allow the latter to be safely removed from the server JSON-RPC API in a subsequent PR.The
BillingAccountSelectorcomponent is used on the individual user settings page:Related Issue(s)
Part of #12685
How to test
Gitpod-somethingteams in the preview environment and sign them up for UBP.The selected cost center is respected. (Easiest way to verify this is to examine the
d_b_users.usageAttributionIdfield in the db).Release Notes
Documentation
Werft options: