Skip to content

Conversation

@laushinka
Copy link
Contributor

Description

Fixes logging object. (context)

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@laushinka laushinka requested a review from a team September 15, 2022 08:20
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 15, 2022
installation,
phase,
});
log.info(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that our typechecking is not catching these..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are correct, type-wise and semantically. 🤷

@roboquat roboquat merged commit 2c14f37 into main Sep 15, 2022
@roboquat roboquat deleted the lau/fix-log branch September 15, 2022 09:49
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants