Skip to content

[server] remove unused isBillingModeEnabled#13089

Merged
roboquat merged 1 commit into
mainfrom
se/remove-unused-flag
Sep 20, 2022
Merged

[server] remove unused isBillingModeEnabled#13089
roboquat merged 1 commit into
mainfrom
se/remove-unused-flag

Conversation

@svenefftinge

Copy link
Copy Markdown
Contributor

Description

Removes unused method and a feature flag for billing mode.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@svenefftinge
svenefftinge requested a review from a team September 19, 2022 13:01
@github-actions github-actions Bot added the team: webapp Issue belongs to the WebApp team label Sep 19, 2022

@geropl geropl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the 🧹

build fails with: ee/src/workspace/gitpod-server-impl.ts(117,1): error TS6133: 'getExperimentsClientForBackend' is declared but its value is never read.

@svenefftinge

svenefftinge commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

/werft run

👍 started the job as gitpod-build-se-remove-unused-flag.3
(with .werft/ from main)

@roboquat
roboquat merged commit f00bf26 into main Sep 20, 2022
@roboquat
roboquat deleted the se/remove-unused-flag branch September 20, 2022 13:06
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants