Only lint in install/kots:lint if env vars are set#13218
Merged
Conversation
mrsimonemms
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to make it easier to run a full
leewaybuild from a Gitpod workspace in https://github.com/gitpod-io/ops/issues/5411. This PR sets default values for REPLICATED_API_TOKEN and REPLICATED_APP to be the empty string and changesinstall/kots:lintsuch that it will skip linting if the values are not set.Related Issue(s)
Part of https://github.com/gitpod-io/ops/issues/5411
How to test
With this change you can run
leeway build install/kots:lintand it will skip the linting which means the package builds:If you specify the build args then it will try to lint (but fail, as I don't have the right credentials)
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide