-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove projects from nav depending on ff #19398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o/gitpod into ft/global-prebuild-list
This will most definetely not solve anything, but...
Sorry :/
T'was an oopsie doopsie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM ✅
I'd two things before merging this:
- Turn the feature flag off (currently is on for all). We can turn back on our release day.
- Adding a redirect to
/repositories, if a user directly goes to/projects.
I hope not 🙈!
I'm happy to discuss this later when we talk. My stance is that we should let users access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approove to unblock the merge
|
Will work on this in #19413 |
Description
Makes it so that projects don't appear in the UI if you have the
configurationsAndPrebuildsfeature flag.Related Issue(s)
Fixes EXP-1322
How to test
Should make the top-level menu item invisible in the preview environment. You can try flipping it for yourself in Configcat to verify its effect.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold