Skip to content

Conversation

@filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Feb 6, 2024

Description

Makes it so that projects don't appear in the UI if you have the configurationsAndPrebuilds feature flag.

Related Issue(s)

Fixes EXP-1322

How to test

Should make the top-level menu item invisible in the preview environment. You can try flipping it for yourself in Configcat to verify its effect.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Base automatically changed from ft/global-prebuild-list to main February 8, 2024 08:21
@roboquat roboquat added size/XXL and removed size/XS labels Feb 8, 2024
@roboquat roboquat added size/XS and removed size/XXL labels Feb 12, 2024
@filiptronicek filiptronicek marked this pull request as ready for review February 12, 2024 08:44
@filiptronicek filiptronicek requested a review from a team as a code owner February 12, 2024 08:44
Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM ✅

I'd two things before merging this:

  • Turn the feature flag off (currently is on for all). We can turn back on our release day.
  • Adding a redirect to /repositories, if a user directly goes to /projects.

@Siddhant-K-code Siddhant-K-code mentioned this pull request Feb 13, 2024
15 tasks
@filiptronicek
Copy link
Member Author

@Siddhant-K-code: Turn the feature flag off (currently is on for all). We can turn back on our release day.

I hope not 🙈! configurationsAndPrebuilds should be on for all non-prod envs, but only enabled internally for us on cloud and dedicated. We surely can also disable for us as well, but I think it will be helpful to verify.

Adding a redirect to /repositories, if a user directly goes to /projects.

I'm happy to discuss this later when we talk. My stance is that we should let users access /projects to ensure a smooth transition (people get gently pushed to the new UI instead of hard redirecting) and old docs links still work.

Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approove to unblock the merge

@filiptronicek
Copy link
Member Author

Will work on this in #19413

@filiptronicek filiptronicek deleted the ft/conditionally-remove-projects branch February 15, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants