Configuration coachmark #19413
Merged
Configuration coachmark #19413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Feb 12, 2024
| optional string signup_goals_other = 10; | ||
| optional string onboarded_timestamp = 11; | ||
| optional string company_size = 12; | ||
| map<string, string> coachmarks_dismissals = 13; |
There was a problem hiding this comment.
I hope to use this for future dialogs of this nature to not bloat the profile object.
filiptronicek
commented
Feb 12, 2024
| } | ||
|
|
||
| // User already knows about the feature | ||
| if (history.location.pathname.startsWith("/repositories")) { |
There was a problem hiding this comment.
Could also dismiss automatically if a user visits /prebuilds. No strong opinion here.
components/dashboard/src/repositories/coachmarks/MigrationCoachmark.tsx
Outdated
Show resolved
Hide resolved
Siddhant-K-code
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Working ✅
Code LGTM (a small suggestion) ✅
We should ensure to release this under the same features flag we are using in #19398, so that it is only visible after our release.
Co-authored-by: Siddhant Khare <siddhant@gitpod.io>
Siddhant-K-code
approved these changes
Feb 14, 2024
15 tasks
svenefftinge
approved these changes
Feb 19, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add coachmarks for letting users know about the transition to Configurations.
Related Issue(s)
Fixes EXP-1017
How to test
Open the preview environment.
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled.