[dashboard] route login to / #3680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
approved these changes
Mar 31, 2021
components/dashboard/src/App.tsx
Outdated
Contributor
There was a problem hiding this comment.
Works ok but could we also update the URL path to / or /workspaces? Now both anonymous and logged in users now see the workspaces list (after logging in) but see the /login path in the URL. Feel free to merge and open a follow up issue for this.
:M: :V: :C:
Contributor
Author
There was a problem hiding this comment.
Good point! I pushed again.
svenefftinge
force-pushed
the
sefftinge/redirect-login-to-for-3674
branch
from
bc639e7 to
7a0e34e
Compare
AlexTugarev
reviewed
Apr 1, 2021
| setLoading(false); | ||
| })(); | ||
| }, []); | ||
| }, [ setUser ]); |
Member
There was a problem hiding this comment.
@svenefftinge we need to change this :-(
this effect causes constant stream of getLoggedInUser requests
jankeromnes
added a commit
that referenced
this pull request
Apr 1, 2021
jankeromnes
added a commit
that referenced
this pull request
Apr 1, 2021
pavan-tri
pushed a commit
to trilogy-group/gitpod
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle /login route properly fixes #3674