[admin] (temp) disable telemetry for gitpod.io#8386
Conversation
e1ddc5b to
be8cf75
Compare
Codecov Report
@@ Coverage Diff @@
## main #8386 +/- ##
=========================================
+ Coverage 8.41% 11.17% +2.75%
=========================================
Files 33 18 -15
Lines 2340 993 -1347
=========================================
- Hits 197 111 -86
+ Misses 2138 880 -1258
+ Partials 5 2 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
|
||
| useEffect(() => { | ||
| if (isGitpodIo()) { | ||
| return; // temporarily disable to avoid hight CPU on the DB |
There was a problem hiding this comment.
Do we still need to disable it since the missing dependency arg is what's causing the infinite loop?
There was a problem hiding this comment.
I think yes, because we should not be giving our users insights or the permission to see/set this page for the whole SAAS instance? 🤔
There was a problem hiding this comment.
It wasn't causing an infinite loop. 😌 It's just on each re-render it was called, instead of a single init call.
There was a problem hiding this comment.
Not sure, if it's only the missing dependency arg. It could also be that this query is too expensive with our large instance DB:
gitpod/components/gitpod-db/src/typeorm/workspace-db-impl.ts
Lines 337 to 344 in 5f6114c
Don't know how to figure that out, though.
There was a problem hiding this comment.
You are right. The useEffect issue was not a big deal, it just amplified the actual problem.
Uh oh!
There was an error while loading. Please reload this page.