Skip to content

Conversation

@Arjun-sna
Copy link
Contributor

Question Response
Version? v1.4.1
Devices tested? iPhone 7, Onplus 5
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes

Description

@Arjun-sna Arjun-sna force-pushed the upgrade_redux_persist branch from ed3dfbc to daf4b3f Compare October 4, 2018 12:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.511% when pulling daf4b3f on Arjun-sna:upgrade_redux_persist into d109ded on gitpoint:master.

@chinesedfan
Copy link
Member

@Arjun-sna Can you share some details of this upgrade, i.e. advantages vs disadvantages?

@housseindjirdeh
Copy link
Member

Looks like there were quite a few API changes, even if there were specific improvements besides changing the API -> always a good idea to stay updated where possible 👍🏾

Thanks a ton @Arjun-sna 🙌

@housseindjirdeh
Copy link
Member

Someone should pull this down and test on their device/emulator before merging however. Will let y’all know when I get the chance to do it today/tomorrow

@housseindjirdeh
Copy link
Member

Works well in my simulator 👍

Thanks again @Arjun-sna!

@housseindjirdeh housseindjirdeh merged commit 4375a46 into gitpoint:master Nov 17, 2018
@Arjun-sna Arjun-sna deleted the upgrade_redux_persist branch December 14, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants